Skip to content
This repository has been archived by the owner on Oct 5, 2023. It is now read-only.

[BUG] Action token and newlines are not added for speech #227

Open
Herohtar opened this issue Dec 29, 2019 · 1 comment
Open

[BUG] Action token and newlines are not added for speech #227

Herohtar opened this issue Dec 29, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@Herohtar
Copy link

Herohtar commented Dec 29, 2019

🐛 Bug Report

Describe the bug
When entering an action (ie, walk across the street) it is formatted to have the following form:

\n> You walk across the street.\n

However, when entering speech like "I'm going over there" it only gets formatted like this:

You say "I'm going over there"

Expected behavior
Action formatting should be consistent for the model to handle them appropriately. Speech actions should have the newlines and > added just like non-speech actions:

\n> You say "I'm going over there"\n
@Herohtar Herohtar added the bug Something isn't working label Dec 29, 2019
@Sporking
Copy link

Also, speech should have a period added inside the quotes, as per normal English rules, unless the user typed a period themselves. This might have an effect on the AI, since it would match more text from typical dialog in books that might have been part of the AI's non-adventure-game-related training set.

Also, if the user's speech ended with a question mark, it might be better to say "You ask", and if it ends with an exclamation point, it might be better to say "You exclaim".

Also, it would be worth experimenting a bit to determine whether this form:

You say "That looks like a dragon."

produces better results from the AI than this form:

"That looks like a dragon." you say.

or this form:

"That looks like a dragon," you say.

since the latter forms are somewhat more natural English spoken dialog (as would be typical in a book, for instance), while the first form might be more typical in some text adventure games.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants