Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #135

Open
10 tasks
koppor opened this issue Nov 29, 2020 · 1 comment
Open
10 tasks

Fix warnings #135

koppor opened this issue Nov 29, 2020 · 1 comment
Assignees

Comments

@koppor
Copy link
Member

koppor commented Nov 29, 2020

  • "Command \@parboxrestore has changed."
  • "csquotes should be loaded after fvextra"
  • filecontents is obsolete
  • eq:test multiply defined
  • eq:test@cref multiply defined
  • footnotehyper warns about: "The footnote environment will not be fully functional, sorry."
  • pgfplots wants to be updated to compat 1.17 from 1.14
  • Use of \deftripstyle should be replaced with \deftriplepagestyle
  • center environment in figure
  • 4 nag warnings and missing font shapes.

Fix or add an ADR.

@Vogel612
Copy link
Collaborator

The changes to @parboxrestore as well as the csquotes loading are connected, but neither is really fixable, since the root cause is loading minted after csquotes. Considering that only the -minted files should load it, it cannot be moved into the config and pushing csquotes into all four tex-files seems like a bad decision.

filecontents is loaded by latexdemo, so I doubt we can fix that.

I have no clue why footnotehyper is complaining, so I unfortunately can't even attempt to fix it.

The pgfplots compat setting is noted to be used for overleaf support. I personally would not mind dropping that support and just forcing compat=latest, but that seems a more complex issue.

Some other fixes are in #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants