PR not reviewed properly #53273
-
|
Hello, Please review #53222. I submitted this PR days ago, but Taylor Otwell closed it with an odd reply, likely due to a misunderstanding. I don't think he even read what I wrote in the description or he checked the code i mean the changes. I just want to ensure that the PR is properly reviewed, even if it's rejected. Sorry for the inconvenience. |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 1 reply
-
|
You should submit a new PR if you wish Taylor to review it again. |
Beta Was this translation helpful? Give feedback.
-
|
Most likely, Taylor will close it again. |
Beta Was this translation helpful? Give feedback.
-
|
Word of advise: Don't submit PRs. What you experienced is not a mistake, it's intentionally. If you were Taylor's friend, he would approve your PR. But otherwise, chances are low that he does. For me, it's just not worth the effort, especially since you never know what his problem was this time. |
Beta Was this translation helpful? Give feedback.
You should submit a new PR if you wish Taylor to review it again.