[L11] Middleware config can be inadvertently overwritten

[nigelfo]

I've found it's easy to inadvertently overwrite the middleware config using the fluent interface:

Middleware config now uses the function withMiddleware() Eg (from Laravel docs) :

->withMiddleware(function (Middleware $middleware) {
    $middleware->web(append: [
        EnsureUserIsSubscribed::class,
    ]);
})

As Application::configure uses a fluent interface I originally added more middleware like this:

->withMiddleware(function (Middleware $middleware) {
    $middleware->web(append: [
        EnsureUserIsSubscribed::class,
    ]);
})
->withMiddleware(function (Middleware $middleware) {
    $middleware->api(prepend: [
        EnsureTokenIsValid::class,
    ]);
})

The causes a new config array to be generated, overwriting the first set of middleware. No errors, no warnings, your middleware will just disappear.

I would expect it to merge the two configs, not overwrite, or at least warn you in the docs!

The correct way (of course) is to ensure there is only one config block:

->withMiddleware(function (Middleware $middleware) {
    $middleware->web(append: [
        EnsureUserIsSubscribed::class,
    ]);

    $middleware->api(prepend: [
        EnsureTokenIsValid::class,
    ]);
})