Basic common tests?

[irazasyed]

Can we have some basic common tests in this skeleton to make things easier just like other classes?

Just an idea.

cc: @themsaid @freekmurze @mpociot Thoughts?

[freekmurze]

Sure, what tests were you thinking of? You could send a PR to the skeleton
😀

On Friday, 12 August 2016, Syed Irfaq R. ⚡️ [email protected]
wrote:

Can we some basic common tests in this skeleton to make things easier just
like other classes?

Just an idea.

cc: @themsaid https://github.com/themsaid @freekmurze
https://github.com/freekmurze @mpociot https://github.com/mpociot
Thoughts?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAdiDdBAdAQaRKRax38D4L7OXyZPz2hoks5qfKrOgaJpZM4JjSMl
.

Freek Van der Herten
https://spatie.be
+32 495 84 27 91

[irazasyed]

All the skeleton related methods that are present right now with guzzle example (Since it's commonly used)?

Sure, I'll send a PR when I start writing. Thought, I'd get started with a skeleton for that as well..lol 😄

[casperboone]

Good idea 😄 . I don't think the tests should include a Guzzle example though, since the skeleton should be very clean in my opinion. However, providing some basic test classes with tests for the code that is actually in the skeleton (like the firing of events in the channel class, update: hopefully no longer necessary because of laravel/framework#14804 😄), would be cool.

It might also be a good idea to list some repos with tests (using Guzzle for instance as you suggested) that can be used as an example. Also, some basic testing guidelines, to keep the tests in all repos kind of uniform, might be nice addition.