Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BulkGate SMS #134

Open
dontfreakout opened this issue Jan 6, 2022 · 2 comments
Open

BulkGate SMS #134

dontfreakout opened this issue Jan 6, 2022 · 2 comments

Comments

@dontfreakout
Copy link

I would like to add BulkGate SMS channel.

@dontfreakout
Copy link
Author

Hi, I followed the instructions from (https://github.com/laravel-notification-channels/channels)

  • Create project from skeleton
  • Implementing channel logic
  • Fork this repo, add it as a remote, and push the channel to a branch.
  • Submit a new PR against this repo for review.

However, creating PR is not possible that way. Github shows this message:

There isn’t anything to compare.
laravel-notification-channels:master and dontfreakout:bulkgate are entirely different commit histories.

Now I'm not sure how to submit a PR to this repo :)

This is my repo: (https://github.com/dontfreakout/bulkgate-laravel-notification-channel/tree/bulkgate)

Thanks for any advice :)

@dontfreakout
Copy link
Author

I figured it out, PR from the new branch worked without a problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant