Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo name is not semantic #9

Open
sinkcup opened this issue Jul 17, 2019 · 0 comments
Open

repo name is not semantic #9

sinkcup opened this issue Jul 17, 2019 · 0 comments
Assignees
@sinkcup
Labels
enhancement New feature or request

Comments

@sinkcup
Copy link
Member

sinkcup commented Jul 17, 2019

bad: https://github.com/laravel-socialite-providers/providers
good: https://github.com/laravel-socialite-providers/socialite-providers

bad: laravel-socialite-providers/wechat
good: laravel-socialite-providers/socialite-wechat

when you fork a repo, you will find "org/providers" comes to "Jim/providers", so repo name should be semantic, should use "org/socialite-providers".
@sinkcup sinkcup changed the title repo name is wrong repo name is not semantic Jul 17, 2019
@sinkcup sinkcup self-assigned this Jul 17, 2019
@sinkcup sinkcup added the enhancement New feature or request label Jul 17, 2019
sinkcup added a commit that referenced this issue Jul 17, 2019
@sinkcup
refactory: semantic name for repo and composer. #9
793dc5b
@sinkcup sinkcup mentioned this issue Jul 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sinkcup sinkcup

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sinkcup