Certbot doesn't seem to provide necessary arguments

[zertap]

When running: certbot certonly --manual --manual-auth-hook /root/certbot-dns-name-com/src/certbot-dns-namecom.py -d domain.tld --agree-tos --email [email protected] --dry-run
I'm getting the following error

manual-auth-hook command "/root/certbot-dns-name-com/src/certbot-dns-namecom.py" returned error code 1
Error output from manual-auth-hook command certbot-dns-namecom.py:
Traceback (most recent call last):
  File "/root/certbot-dns-name-com/src/certbot-dns-namecom.py", line 49, in <module>
    cmd = sys.argv[1]
IndexError: list index out of range

Debian 11
certbot 1.12.0

[12joan]

Newer versions of certbot don't pass an argument, but instead call separate hooks for add and cleanup. I solved this by wrapping the Python script in two Bash scripts. Certbot docs

[zertap]

Right, thanks!

I think the code in the repository should be fixed to have separate deletion and addition scripts, but for now this kind of workaround does it.

[root@nginx namecom-renewal]# ls -l
total 26
-rwxr-xr-x 1 root root 3815 Apr  5 06:03 certbot-dns-namecom.py
-rw-r--r-- 1 root root  133 Apr  5 06:29 config.json
-rwxr-xr-x 1 root root  139 Apr  5 06:16 dns-namecom-add.bash
-rwxr-xr-x 1 root root  141 Apr  5 06:16 dns-namecom-clean.bash

[root@nginx namecom-renewal]# cat dns-namecom-add.bash
#! /usr/bin/bash

export CERTBOT_DNS_NAMECOM_CONFIG=/root/namecom-renewal/config.json

/root/namecom-renewal/certbot-dns-namecom.py add $@

[root@nginx namecom-renewal]# cat dns-namecom-clean.bash
#! /usr/bin/bash

export CERTBOT_DNS_NAMECOM_CONFIG=/root/namecom-renewal/config.json

/root/namecom-renewal/certbot-dns-namecom.py clean $@

And then running with: certbot certonly --manual --preferred-challenges=dns --manual-auth-hook /root/namecom-renewal/dns-namecom-add.bash --manual-cleanup-hook /root/namecom-renewal/dns-namecom-clean.bash -d example.tld --agree-tos --email [email protected] --dry-run