Open
Description
Hi everyone,
In #64 del method (lines 326-328) was removed from VectorStores.PGVector. While, after a bit of investigation, I believe this was a right decision, I would say it might need to be reintroduced. The way code currently is, the Engine object (stored in self._engine) doesn't dispose properly, upon deletion, if it is initialized from string by user through the connection parameter (as for lines 432 to 438).
I have faced "too many connections" error that seem to be fixed by disposing the engine with .dispose.
Metadata
Metadata
Assignees
Labels
No labels