Skip to content

Engine object is not being properly disposed in PGVector #126

Open
@ladi-pomsar

Description

@ladi-pomsar

Hi everyone,

In #64 del method (lines 326-328) was removed from VectorStores.PGVector. While, after a bit of investigation, I believe this was a right decision, I would say it might need to be reintroduced. The way code currently is, the Engine object (stored in self._engine) doesn't dispose properly, upon deletion, if it is initialized from string by user through the connection parameter (as for lines 432 to 438).

I have faced "too many connections" error that seem to be fixed by disposing the engine with .dispose.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions