Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare library to work with react 17. #19

Open
aleksuk opened this issue Nov 14, 2019 · 1 comment
Open

Prepare library to work with react 17. #19

aleksuk opened this issue Nov 14, 2019 · 1 comment
Assignees
@fjaguero

Comments

@aleksuk
Copy link

aleksuk commented Nov 14, 2019

Library uses componentWillUpdate life cycle hook which is deprecated and will be removed in the react@17.

Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: TagsInput
@fjaguero
Copy link
Member

Thanks for the report @aleksuk. I will have a look.

@fjaguero fjaguero self-assigned this Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fjaguero fjaguero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fjaguero @aleksuk