Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lando/pkg-action
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.0
Choose a base ref
...
head repository: lando/pkg-action
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 17 commits
  • 13 files changed
  • 3 contributors

Commits on Mar 14, 2024

  1. v5 (#9)

    * push up some prelim tests
    
    * push up some prelim tests 2
    
    * push up some prelim tests 3
    
    * first pass on only emulate if needed
    
    * arch mismatch tests
    
    * arch mismatch tests 2
    
    * arch mismatch tests 3
    
    * arm native test
    
    * arm native test 2
    
    * readme
    
    * release tag
    pirog authored Mar 14, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    a131c77 View commit details
  2. Copy the full SHA
    4bc466f View commit details
  3. oooh that DS_Store

    pirog committed Mar 14, 2024
    Copy the full SHA
    134fe08 View commit details
  4. deyarn

    pirog committed Mar 14, 2024
    Copy the full SHA
    bd0cca4 View commit details

Commits on Mar 28, 2024

  1. upra

    pirog authored Mar 28, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    f51ee14 View commit details

Commits on Apr 5, 2024

  1. update contrib things

    pirog committed Apr 5, 2024
    Copy the full SHA
    c041385 View commit details

Commits on Oct 26, 2024

  1. Copy the full SHA
    3edcc0a View commit details
  2. Copy the full SHA
    4f0ebfe View commit details
  3. Copy the full SHA
    ee07f03 View commit details
  4. Copy the full SHA
    9fcc18d View commit details
  5. Copy the full SHA
    6986eaa View commit details
  6. update prepare-release-action

    pirog committed Oct 26, 2024
    Copy the full SHA
    20b15f8 View commit details
  7. Copy the full SHA
    ce6ce84 View commit details

Commits on Nov 14, 2024

  1. rework to handle dynamic filename output (#11)

    * rework to handle dynamic filename output
    
    * add output verifier and bump to setup-node@v4
    
    * fixed output verifier and added filename test
    
    * update docs
    
    * added target output to output verification
    pirog authored Nov 14, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    e58618c View commit details
  2. Copy the full SHA
    c09d1f6 View commit details

Commits on Nov 15, 2024

  1. updated to actions/upload|download-artifact@v4 (#12)

    * updated to actions/upload|download-artifact@v4
    
    * update sync tags since this is probably breaking
    
    * remove duplicate upload keyz
    pirog authored Nov 15, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    2e75f33 View commit details
  2. Copy the full SHA
    c1540a1 View commit details
22 changes: 22 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
### Bare minimum self-checks

> [What do you think of a person who only does the bare minimum?](https://getyarn.io/yarn-clip/dcf80710-425e-478b-bde1-c107bd11e849)
- [ ] I've updated this PR with the latest code from `main`
- [ ] I've done a cursory QA pass of my code locally
- [ ] I've ensured all automated status check and tests pass
- [ ] I've [connected this PR to an issue](https://help.zenhub.com/support/solutions/articles/43000010350-connecting-pull-requests-to-github-issues)

### Pieces of flare

- [ ] I've written a unit or functional test for my code
- [ ] I've updated relevant documentation it my code changes it
- [ ] I've updated this repo's README if my code changes it
- [ ] I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

### Finally

- [ ] I've [requested a review](https://help.github.com/en/articles/requesting-a-pull-request-review) with relevant people

If you have any issues or need help please join the `#contributors` channel in the [Lando slack](https://www.launchpass.com/devwithlando) and someone will gladly help you out!

You can also check out the [coder guide](https://docs.lando.dev/contrib/coder.html).
27 changes: 27 additions & 0 deletions .github/workflows/label-add-to-project.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Add to DevOps Project

on:
issues:
types: [labeled]
pull_request:
types: [labeled]

jobs:
add_to_project:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- ubuntu-24.04
flag:
- flag

steps:
- name: Add issue/PR to GitHub Project
if: github.event.label.name == '${{ matrix.flag }}'
uses: actions/add-to-project@v1.0.0
with:
project-url: https://github.com/orgs/lando/projects/10
github-token: ${{ secrets.SHADOW_COUNCIL_ESCALATOR }}
labeled: ${{ matrix.flag }}
45 changes: 45 additions & 0 deletions .github/workflows/pr-armed-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: ARMed Tests

on:
pull_request:

jobs:
basic-arm-test:
runs-on: macos-14
steps:
- name: Checkout action code
uses: actions/checkout@v4
- name: Run Pkg Action
uses: ./
with:
entrypoint: bin/test
upload: false
- name: Test Bin
run: |
chmod +x dist/@lando/pkg-action
dist/@lando/pkg-action --version
file dist/@lando/pkg-action | grep "Mach-O 64-bit executable arm64"
basic-cross-os-armed-tests:
runs-on: ${{ matrix.runner }}
strategy:
fail-fast: false
matrix:
runner:
- macos-14
- ubuntu-24.04
os:
- linux
- macos
- win

steps:
- name: Checkout action code
uses: actions/checkout@v4
- name: Run Pkg Action
uses: ./
with:
entrypoint: bin/test
arch: arm64
os: ${{ matrix.os }}
upload: false
71 changes: 61 additions & 10 deletions .github/workflows/pr-func-tests.yml
Original file line number Diff line number Diff line change
@@ -5,37 +5,60 @@ on:

jobs:
basic-func-test:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
steps:
- name: Checkout action code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Run Pkg Action
uses: ./
id: basic-func-test
with:
entrypoint: bin/test

basic-func-upload-key-test:
runs-on: ubuntu-24.04
steps:
- name: Checkout action code
uses: actions/checkout@v4
- name: Run Pkg Action
uses: ./
with:
entrypoint: bin/test
upload-key: something-else-${{ github.sha }}

basic-func-filename-test:
runs-on: ubuntu-24.04
steps:
- name: Checkout action code
uses: actions/checkout@v4
- name: Run Pkg Action
uses: ./
with:
entrypoint: bin/test
upload-key: another-thing-${{ github.sha }}
filename: bob

basic-cross-platform-test:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- macos-11
- ubuntu-20.04
- macos-13
- macos-14
- ubuntu-24.04
- windows-2022
steps:
- name: Checkout action code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Run Pkg Action
uses: ./
id: basic-func-test
with:
entrypoint: bin/test
upload: false

basic-cross-everything-test:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
@@ -51,17 +74,45 @@ jobs:
pkg:
- "pkg@5.8.0"
- "pkg@5.8.1"
- "@yao-pkg/pkg@5.10.0"
- "@yao-pkg/pkg@5.11.5"
steps:
- name: Checkout action code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Run Pkg Action
uses: ./
id: basic-func-test
with:
arch: ${{ matrix.arch }}
entrypoint: bin/test
node-version: ${{ matrix.node-version }}
os: ${{ matrix.os }}
pkg: ${{ matrix.pkg }}
upload: false

download:
runs-on: ubuntu-24.04
needs:
- basic-func-test
- basic-func-upload-key-test
env:
TERM: xterm
strategy:
fail-fast: false
matrix:
file:
- pkg-action-node20-linux-x64-${{ github.sha }}
- something-else-${{ github.sha }}
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Download ${{ matrix.file }}
uses: actions/download-artifact@v4
with:
name: ${{ matrix.file }}
path: dist
- name: Test downloads
run: |
echo "${{ matrix.file }}"
ls -lsa dist
chmod +x dist/pkg-action
dist/pkg-action --version
55 changes: 31 additions & 24 deletions .github/workflows/pr-test-inputs.yml
Original file line number Diff line number Diff line change
@@ -5,10 +5,10 @@ on:

jobs:
test-default-inputs:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
steps:
- name: Checkout action code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Run Pkg Action
uses: ./
id: default-input-tests
@@ -29,7 +29,7 @@ jobs:
- name: "TEST: should set the correct artifact-key"
if: always()
run: |
if [ "${{ steps.default-input-tests.outputs.artifact-key }}" == "pkg-action-node16-linux-x64-${{ github.sha }}" ]; then
if [ "${{ steps.default-input-tests.outputs.artifact-key }}" == "pkg-action-node20-linux-x64-${{ github.sha }}" ]; then
echo "::notice title=TEST PASSED::Output artifact key set from defaults correctly"
else
echo "::error title=TEST FAILED!::Output artifact key not set correctly"
@@ -38,17 +38,22 @@ jobs:
shell: bash

test-arch-inputs:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
arch:
- X86
- X64
- amd64
- x64
- ARM
- ARM64
- aarch64
- arm64
steps:
- name: Checkout action code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Run Pkg Action
uses: ./
id: arch-input-tests
@@ -60,29 +65,29 @@ jobs:
- name: "TEST: should map ${{ matrix.arch }} to x64 or arm64 as needed"
if: always()
run: |
if [ "${{ matrix.arch }}" == "x64" ]; then
if [ "${{ steps.arch-input-tests.outputs.artifact-key }}" == "pkg-action-node16-linux-x64-${{ github.sha }}" ]; then
if [ "${{ matrix.arch }}" == "X86" ] || [ "${{ matrix.arch }}" == "X64" ]; then
if [ "${{ steps.arch-input-tests.outputs.artifact-key }}" == "pkg-action-node20-linux-x64-${{ github.sha }}" ]; then
echo "::notice title=TEST PASSED::Arch mapping from ${{ matrix.arch }} to x64 correctly"
else
echo "::error title=TEST FAILED!::Arch not mapping from ${{ matrix.arch }} to x64 correctly"
exit 1
fi
elif [ "${{ matrix.arch }}" == "amd64" ]; then
if [ "${{ steps.arch-input-tests.outputs.artifact-key }}" == "pkg-action-node16-linux-x64-${{ github.sha }}" ]; then
elif [ "${{ matrix.arch }}" == "amd64" ] || [ "${{ matrix.arch }}" == "x64" ]; then
if [ "${{ steps.arch-input-tests.outputs.artifact-key }}" == "pkg-action-node20-linux-x64-${{ github.sha }}" ]; then
echo "::notice title=TEST PASSED::Arch mapping from ${{ matrix.arch }} to x64 correctly"
else
echo "::error title=TEST FAILED!::Arch not mapping from ${{ matrix.arch }} to x64 correctly"
exit 2
fi
elif [ "${{ matrix.arch }}" == "arm64" ]; then
if [ "${{ steps.arch-input-tests.outputs.artifact-key }}" == "pkg-action-node16-linux-arm64-${{ github.sha }}" ]; then
elif [ "${{ matrix.arch }}" == "ARM" ] || [ "${{ matrix.arch }}" == "ARM64" ]; then
if [ "${{ steps.arch-input-tests.outputs.artifact-key }}" == "pkg-action-node20-linux-arm64-${{ github.sha }}" ]; then
echo "::notice title=TEST PASSED::Arch mapping from ${{ matrix.arch }} to arm64 correctly"
else
echo "::error title=TEST FAILED!::Arch not mapping from ${{ matrix.arch }} to arm64 correctly"
exit 3
fi
elif [ "${{ matrix.arch }}" == "aarch64" ]; then
if [ "${{ steps.arch-input-tests.outputs.artifact-key }}" == "pkg-action-node16-linux-arm64-${{ github.sha }}" ]; then
elif [ "${{ matrix.arch }}" == "arm64" ] || [ "${{ matrix.arch }}" == "aarch64" ]; then
if [ "${{ steps.arch-input-tests.outputs.artifact-key }}" == "pkg-action-node20-linux-arm64-${{ github.sha }}" ]; then
echo "::notice title=TEST PASSED::Arch mapping from ${{ matrix.arch }} to arm64 correctly"
else
echo "::error title=TEST FAILED!::Arch not mapping from ${{ matrix.arch }} to arm64 correctly"
@@ -95,15 +100,16 @@ jobs:
test-runner-os:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- macos-11
- ubuntu-20.04
- macos-13
- ubuntu-24.04
- windows-2022

steps:
- name: Checkout action code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Run Pkg Action
uses: ./
id: runner-os-tests
@@ -115,21 +121,21 @@ jobs:
if: always()
run: |
if [ "${{ runner.os }}" == "Linux" ]; then
if [ "${{ steps.runner-os-tests.outputs.artifact-key }}" == "pkg-action-node16-linux-x64-${{ github.sha }}" ]; then
if [ "${{ steps.runner-os-tests.outputs.artifact-key }}" == "pkg-action-node20-linux-x64-${{ github.sha }}" ]; then
echo "::notice title=TEST PASSED::Runner OS mapping to linux correctly"
else
echo "::error title=TEST FAILED!::Runner OS mapping not mapping to linux correctly"
exit 1
fi
elif [ "${{ runner.os }}" == "macOS" ]; then
if [ "${{ steps.runner-os-tests.outputs.artifact-key }}" == "pkg-action-node16-macos-x64-${{ github.sha }}" ]; then
if [ "${{ steps.runner-os-tests.outputs.artifact-key }}" == "pkg-action-node20-macos-x64-${{ github.sha }}" ]; then
echo "::notice title=TEST PASSED::Runner OS mapping to macos correctly"
else
echo "::error title=TEST FAILED!::Runner OS mapping not mapping to macos correctly"
exit 2
fi
elif [ "${{ runner.os }}" == "Windows" ]; then
if [ "${{ steps.runner-os-tests.outputs.artifact-key }}" == "pkg-action-node16-win-x64-${{ github.sha }}" ]; then
if [ "${{ steps.runner-os-tests.outputs.artifact-key }}" == "pkg-action-node20-win-x64-${{ github.sha }}" ]; then
echo "::notice title=TEST PASSED::Runner OS mapping to win correctly"
else
echo "::error title=TEST FAILED!::Runner OS mapping not mapping to win correctly"
@@ -139,8 +145,9 @@ jobs:
shell: bash

test-os-input:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
os:
- macos
@@ -149,7 +156,7 @@ jobs:

steps:
- name: Checkout action code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Run Pkg Action
uses: ./
id: os-input-tests
@@ -162,21 +169,21 @@ jobs:
if: always()
run: |
if [ "${{ matrix.os }}" == "linux" ]; then
if [ "${{ steps.os-input-tests.outputs.artifact-key }}" == "pkg-action-node16-linux-x64-${{ github.sha }}" ]; then
if [ "${{ steps.os-input-tests.outputs.artifact-key }}" == "pkg-action-node20-linux-x64-${{ github.sha }}" ]; then
echo "::notice title=TEST PASSED::OS input ${{ matrix.os }} being used correctly"
else
echo "::error title=TEST FAILED!::OS input not being using ${{ matrix.os }} correctly"
exit 1
fi
elif [ "${{ matrix.os }}" == "macos" ]; then
if [ "${{ steps.os-input-tests.outputs.artifact-key }}" == "pkg-action-node16-macos-x64-${{ github.sha }}" ]; then
if [ "${{ steps.os-input-tests.outputs.artifact-key }}" == "pkg-action-node20-macos-x64-${{ github.sha }}" ]; then
echo "::notice title=TEST PASSED::OS input ${{ matrix.os }} being used correctly"
else
echo "::error title=TEST FAILED!::OS input not being using ${{ matrix.os }} correctly"
exit 2
fi
elif [ "${{ matrix.os }}" == "win" ]; then
if [ "${{ steps.os-input-tests.outputs.artifact-key }}" == "pkg-action-node16-win-x64-${{ github.sha }}" ]; then
if [ "${{ steps.os-input-tests.outputs.artifact-key }}" == "pkg-action-node20-win-x64-${{ github.sha }}" ]; then
echo "::notice title=TEST PASSED::OS input ${{ matrix.os }} being used correctly"
else
echo "::error title=TEST FAILED!::OS input not being using ${{ matrix.os }} correctly"
Loading