Skip to content

scripts/sql-import.sh unintentionally swallows exit code when a database import fails. #182

@codebymikey

Description

@codebymikey

eval "$CMD" && lando_green "Import complete!" || lando_red "Import failed."

has an OR operator which calls lando_red "Import failed." and unintentionally swallows the original exit code failure.

This is made more apparent when importing a database dump affected by the mariadb sandbox breaking change - https://mariadb.org/mariadb-dump-file-compatibility-change/

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions