Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight field for donor #100

Open
Zethson opened this issue Jan 21, 2025 · 3 comments
Open

Weight field for donor #100

Zethson opened this issue Jan 21, 2025 · 3 comments
Assignees

Comments

@Zethson
Copy link
Member

Zethson commented Jan 21, 2025

Saw that hubmap donors also have weights. Not in the official but it's still stored.

@sunnyosun we can of course always store more information and should keep it limited. However, I think that this is still pretty essential information.

@Zethson Zethson self-assigned this Jan 21, 2025
@falexwolf
Copy link
Member

falexwolf commented Jan 21, 2025

There will be 50 similar fields. My immediate intuition is that these should all go into the _aux JSON.

@sunnyosun
Copy link
Member

There will be 50 similar fields. My immediate intuition is that these should all go into the _aux JSON.

Agreed.

@falexwolf
Copy link
Member

falexwolf commented Jan 21, 2025

We should work out a schema, but my intuition is that the below is a good starting point.

"aux_fields": {
    "weight": 20.5,
    # other fields 
}

This is explicit enough so that we can extend the content of ._aux while exposing these to the user just like regular fields:

Donor.filter(weight__lt=...)
donor.weight  # property that points to the content in the json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants