Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange convention for branch arg in install_lamindb() #45

Closed
falexwolf opened this issue Jan 11, 2025 · 2 comments · Fixed by #46
Closed

Strange convention for branch arg in install_lamindb() #45

falexwolf opened this issue Jan 11, 2025 · 2 comments · Fixed by #46

Comments

@falexwolf
Copy link
Member

Re:

if branch == "main":

Can we change the if condition from if branch == "main" to if branch != "release"?

@Koncopd @Zethson @sunnyosun

It took me a while that it installs an inconsistent state on the lamindb v1 branch (or any other pr branch).

@falexwolf falexwolf linked a pull request Jan 11, 2025 that will close this issue
@falexwolf
Copy link
Member Author

It made bionty CI error here laminlabs/bionty#178

image

Re-running, I think it should work now.

@falexwolf
Copy link
Member Author

Yeah, works now. I think this was a bug. But you tell me if this was on purpose.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant