Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - HTTPS Self Links Broken for Ports Other than 443 #3

Open
weierophinney opened this issue Dec 31, 2019 · 2 comments
Open

[BUG] - HTTPS Self Links Broken for Ports Other than 443 #3

weierophinney opened this issue Dec 31, 2019 · 2 comments

Comments

@weierophinney
Copy link
Member

When using HTTPS with a port other than 443, the self links returned remain HTTP.

Please see: https://github.com/zendframework/zend-view/blob/master/src/Helper/ServerUrl.php#L149

There are plenty of use cases where people will use ports other than 443 for their HTTPS needs. I believe this needs to be refactored to be less strict.

I'm happy to make the PR contribution, but I wanted to submit the issue first to make sure this doesn't break some standard.


Originally posted by @jbh at zendframework/zend-view#194

@weierophinney
Copy link
Member Author

👍 for a PR for this!


Originally posted by @weierophinney at zendframework/zend-view#194 (comment)

@weierophinney
Copy link
Member Author

Great. I'll work on doing that within the next two days. I have some other tasks in queue.


Originally posted by @jbh at zendframework/zend-view#194 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant