-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial V3 Migration Guide #253
Conversation
gsteel
commented
Jun 12, 2024
•
edited
Loading
edited
- Closes Create migration guide for version 3 #251
- Closes Add example code to the migration guide for dealing with final validators #292
b0ce318
to
7aa7bcf
Compare
ade1457
to
619812e
Compare
8a4b1b1
to
ffb705e
Compare
ffb705e
to
2082659
Compare
@froschdesign - Could you please cast your eyes over this to see if I'm going in the right direction. It's getting pretty big and I'd appreciate a bit of feedback before I put too much more effort into it in case I'm doing a terrible job!! |
I must apologise, because of course I've looked at every change to this pull request so far, but left you in the dark about it. |
Thank you @froschdesign 🙏 |
35e0662
to
bdc6e7e
Compare
289e1e3
to
285478c
Compare
@gsteel |
For the DB validators, Given that If MVC:3 were to receive ServiceManager:4 support, then Validator:3 is theoretically compatible, once Filter, InputFilter, and Form are. I think we should just state that Validator:3 is not compatible with MVC until SM:4 support is available there - Whether that appears in MVC:3 or MVC:4 is then not Validators' concern (??) |
@gsteel |
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Also updates the support options section in the hostname docs with the correct option names Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
285478c
to
5cfabd1
Compare
Thanks @froschdesign - I was just actually writing something about DB - This is what I cam up with, but I'll not commit it and leave this up to you:
|
Signed-off-by: George Steel <[email protected]>
@gsteel |
Do you mean automatically register the delegator in ConfigProvider and Module? I have no problem with that - I'm surprised it wasn't done before looking at the docs that you linked! |
My current idea:
|
Sounds like a good plan to me, however, it's a fair bit of work for legacy stuff that people should be migrating away from, even though it will be a clear benefit to users. Is it worth the effort? |
The point is quite right, but we don't offer an alternative and then also say that version 3 doesn't work with laminas-mvc. |
@froschdesign Can this be merged as is? And, can we amend docs post 3.0 release? I'm keen to get 3.0 out the door to enable work on dependents. Are there any other blockers I'm not considering? |
Sure, go for it! |