Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Service Manager v4 #267

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Upgrade to Service Manager v4 #267

merged 4 commits into from
Jul 3, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jun 17, 2024 •
edited
Loading

Q A
BC Break yes
New Feature yes

Description

Initial support for Service Manager v4

  • Remove the shipped CSRF validator
  • Remove dependency on laminas-session
  • Support Service Manager v4 in laminas-i18n, or swap the dependency with the proposed laminas-translator component
  • Remove temporary dev branch for i18n in composer.json

Related laminas/laminas-session#86

@gsteel gsteel added this to the 3.0.0 milestone Jun 17, 2024
gsteel
gsteel commented Jun 17, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@gsteel gsteel mentioned this pull request Jun 17, 2024
Merged
@gsteel gsteel marked this pull request as draft June 17, 2024 22:16
@gsteel gsteel force-pushed the v3/sm-v4 branch 2 times, most recently from adf2270 to f9571b7 Compare June 19, 2024 15:23
@Zombaya Zombaya mentioned this pull request Jun 25, 2024
Closed
This was linked to issues Jun 25, 2024
Need support for laminas/laminas-servicemanager v4 #206
Closed
Drop Service Manager v2 Compatibility #131
Closed
@gsteel gsteel force-pushed the v3/sm-v4 branch 2 times, most recently from ff70409 to 5bd9f56 Compare June 28, 2024 20:04
@gsteel
Copy link
Member Author

gsteel commented Jul 2, 2024

Needs #301 and a rebase

@gsteel gsteel marked this pull request as ready for review July 2, 2024 18:26
froschdesign
froschdesign approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@gsteel
Copy link
Member Author

gsteel commented Jul 3, 2024

Thanks @froschdesign :)

@gsteel gsteel self-assigned this Jul 3, 2024
@gsteel gsteel merged commit 0ceb5b8 into laminas:3.0.x Jul 3, 2024
11 of 12 checks passed
@froschdesign
Copy link
Member

Sorry for the delay, I had to look at the CommonPluginManagerTrait of laminas-servicemanager.

Ocramius
Ocramius reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my PoV, 🚢

src/ValidatorChain.php Show resolved Hide resolved
@gsteel gsteel deleted the v3/sm-v4 branch July 3, 2024 18:36
@gsteel
Copy link
Member Author

gsteel commented Jul 3, 2024

Thanks for the reviews @froschdesign and @Ocramius :)

@gsteel gsteel mentioned this pull request Jul 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius left review comments

@boesing boesing boesing left review comments

@froschdesign froschdesign froschdesign approved these changes

Assignees

@gsteel gsteel

Labels
BC Break Enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Need support for laminas/laminas-servicemanager v4 Drop Service Manager v2 Compatibility
4 participants
@gsteel @froschdesign @Ocramius @boesing