Merge pull request #30 from sjokkateer/improvement/utils-remove-redun…

…dant-check UTILS: Remove redundant check in `Utils::getStatusCode()`
laminas · Jul 23, 2022 · aa47a70 · aa47a70
2 parents 29461a7 + c2dd74e
commit aa47a70
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/Utils.php b/src/Utils.php
@@ -32,7 +32,7 @@ public static function getStatusCode(Throwable $error, ResponseInterface $respon
         }
 
         $status = $response->getStatusCode();
-        if (! $status || $status < 400 || $status >= 600) {
+        if ($status < 400 || $status >= 600) {
             $status = 500;
         }
         return $status;

diff --git a/test/UtilsTest.php b/test/UtilsTest.php
@@ -13,6 +13,7 @@
 use Laminas\Stratigility\Utils;
 use PHPUnit\Framework\Assert;
 use PHPUnit\Framework\TestCase;
+use Psr\Http\Message\ResponseInterface;
 use ReflectionClass;
 
 class UtilsTest extends TestCase
@@ -32,4 +33,19 @@ public function testGetStatusCodeNotFooledBySneakyStringsWithLeadingDigits(): vo
 
         Assert::assertEquals(418, $actual);
     }
+
+    public function testGetStatusCodeZeroExpectedStatusCodeFiveHundredReturned(): void
+    {
+        $statusCode = 0;
+
+        $response = $this->createMock(ResponseInterface::class);
+        $response
+            ->method('getStatusCode')
+            ->willReturn($statusCode);
+
+        $actualStatusCode   = Utils::getStatusCode(new Exception(), $response);
+        $expectedStatusCode = 500;
+
+        static::assertEquals($expectedStatusCode, $actualStatusCode);
+    }
 }