Update session bootstrap code to use the same config key used in Initializing the Session Manager #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the Session Manager Signed-off-by: dapphp <[email protected]>
|
@dapphp
All code for the module class should be deleted from the documentation because this code should not be used in an application. And as a demonstration, it is only a deterrent. |
Ocramius
approved these changes
Feb 15, 2022
|
@froschdesign ah, should this be closed instead? 🤔 |
This was
linked to
issues
Feb 16, 2022
|
The configuration via the module class is a horror and sheds a bad light on this component. I will rewrite the entire page next weekend. @dapphp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix to a code example in the session manager documentation.
The section "Initializing the Session Manager" defines example configuration for the session manager using the key
session_manager, however, the corresponding code for bootstrapping the session and configuring the session manager are using the keysessionto look for this configuration. This commit updates the code to use to the correct config keysession_managerinstead ofsession.