Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bc\break] Remove deprecated and validators auto injections #7

Open
1 task done
weierophinney opened this issue Dec 31, 2019 · 5 comments
Open
1 task done

Comments

@weierophinney
Copy link
Member

  • Remove AllowEmpty / ContinueIfEmpty deprecated on 2.4.8.
    Zend\Validator\NotEmpty should be added to the ValidatorChain when expected.
  • Remove UploadFile validator auto injection
    Zend\Validator\File\UploadFile should be added to the ValidatorChain when expected.

ToDo:

  • review coverage drop when uncovered lines grow

Originally posted by @Maks3w at zendframework/zend-inputfilter#83

@weierophinney
Copy link
Member Author

Code coverage drop its for a difference between phpunit code coverage versions.


Originally posted by @Maks3w at zendframework/zend-inputfilter#83 (comment)

@weierophinney
Copy link
Member Author

@Maks3w can you drop into the summary how users can emulate the behavior using validators? Most will likely see this issue, see that the functionality was removed, but not know how to accomplish the behavior on their own.

Which brings me to the next point: can you start a migration/changes document detailing the change in behavior, please?


Originally posted by @weierophinney at zendframework/zend-inputfilter#83 (comment)

@weierophinney
Copy link
Member Author

@Maks3w Are you still working on this?


Originally posted by @DASPRiD at zendframework/zend-inputfilter#83 (comment)

@weierophinney
Copy link
Member Author

I'm not sure if continue with this or rewrite the component. There is not urgency for to merge this


Originally posted by @Maks3w at zendframework/zend-inputfilter#83 (comment)

@cooperaj
Copy link

zendframework/zend-inputfilter#9 this issue just took up a whole afternoon. I was neck deep in filter chain debugging when a colleague found the above issue and we were able to turn off the auto injection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants