Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for V3 and V4 #11

Open
4 of 9 tasks
weierophinney opened this issue Dec 31, 2019 · 8 comments
Open
4 of 9 tasks

Roadmap for V3 and V4 #11

weierophinney opened this issue Dec 31, 2019 · 8 comments

Comments

@weierophinney
Copy link
Member

Proposal of roadmap for next major versions.

V3:
V3 should silently fail if any deprecation feature is used. i.e. No file/method removal/rename is allowed.

  • Deprecate Continue If Empty & AllowEmpty
  • Silently ignore continue_if_empty / allow_empty options
  • Let Input validate unknown value (not-set) or know value.
  • Leverage InputFilter from apply complex rules for to determinate if input is valid/invalid
  • Add a resetX method for clear the class state

V4:
V4 does not (currently) restrict any bc break type.

  • Remove deprecated features
  • Fix class inheritance (subclasses must follow the api contract set by the parent) Affected: CollectionInputFilter, ArrayInput and FileInput
  • Make classes stateless
  • Adapted for zend-validator v3

Originally posted by @Maks3w at zendframework/zend-inputfilter#39

@weierophinney
Copy link
Member Author

Hi,

We shoudl also have a look at the refactor I did: zendframework/zend-inputfilter#13

It simplified A LOT of things regarding to continue/allow_empty, stateless, refactored collection input filter... and a lot of other things. I did that a lot of time ago so I don't exactly remember, but this refactor mostly answered to most of the problems you are referring to :).

I will start working again on this, but first we'll need to have the stateless zend-validator and zend-filter.


Originally posted by @bakura10 at zendframework/zend-inputfilter#39 (comment)

@weierophinney
Copy link
Member Author

What is the status for the stateless input filters?


Originally posted by @RalfEggert at zendframework/zend-inputfilter#39 (comment)

@weierophinney
Copy link
Member Author

@RalfEggert Still in planning stages, though @bakura10 has done significant work on a fork he's maintaining. (I've asked him to document usage so I can actually evaluate the changes and the migration/usage impact.)


Originally posted by @weierophinney at zendframework/zend-inputfilter#39 (comment)

@weierophinney
Copy link
Member Author

Stateless input filter can only be done once we have stateless validators :).


Originally posted by @bakura10 at zendframework/zend-inputfilter#39 (comment)

@weierophinney
Copy link
Member Author

What do You think of renaming this component to something more accurate? I dont know, maybe inputparser?
Inputfilter name is very confusing. What it does is filtration and validation. For someone who does not know Zend libraries it is hard to find the difference between filter and inputfilter.


Originally posted by @xorock at zendframework/zend-inputfilter#39 (comment)

@weierophinney
Copy link
Member Author

@bakura10 @weierophinney What is the status of this? Is it being abandoned in favor of the eventually up-coming zend-datavalidator in the future?


Originally posted by @thexpand at zendframework/zend-inputfilter#39 (comment)

@weierophinney
Copy link
Member Author

@thexpand

Is it being abandoned in favor of the eventually up-coming zend-datavalidator in the future?

Please keep in mind that the input-filter is doing something more than validation for values. The zend-datavalidator will replace zend-validator and not zend-inputfilter.


Originally posted by @froschdesign at zendframework/zend-inputfilter#39 (comment)

@weierophinney
Copy link
Member Author

That's actually still to be determined. There's a fair amount of cross over
in how validators and inputs report errors, and my current work has been
around adding the input/data set functionality to the new component.

On Mon, Aug 13, 2018, 3:39 AM Frank Brückner [email protected]
wrote:

@thexpand https://github.com/thexpand

Is it being abandoned in favor of the eventually up-coming
zend-datavalidator in the future?

Please keep in mind that the input-filter is doing something more than
validation for values. The zend-datavalidator
https://github.com/weierophinney/zend-datavalidator will replace
zend-validator and not zend-inputfilter.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
zendframework/zend-inputfilter#39 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABlV7_eltEVvx0oTyH-eRa0wXVewqOKks5uQTs_gaJpZM4FxUDt
.


Originally posted by @weierophinney at zendframework/zend-inputfilter#39 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant