Check for an instance of the DateTimeInterface instead of DateTime in DateTimeFormatter

[kernusr]

Bug Report

Q	A
Version(s)	2.30.0

Summary

Why are you checking for an instance of the DateTime and not a DateTimeInterface?

laminas-filter/src/DateTimeFormatter.php

Line 89 in 97e3ce0

if (! is_string($value) && ! is_int($value) && ! $value instanceof DateTime) {

Is there some secret meaning in this?

Current behavior

In my application, there may be a situation when I create a DateTimeImmutable and pass it in a DateTimeFormatter,
expected a formatted string od date/time in return, but get my object back

How to reproduce

$filter = new DateTimeFormatter();

$date = new DateTimeImmutable($inputDate, $inputTimezone);

$start_date = $filter->filter($date->add(new \DateInterval('PT1H')));
$end_date = $filter->filter($date->add(new \DateInterval('PT7H')));

[froschdesign]

Is there some secret meaning in this?

Maybe because this interface did not exist back then?! 🤷‍♂️

[gsteel]

Can confirm that back in 2013, we were dealing with 5.3! Amazed this hasn't been discovered before.

A patch would be great @kernusr 👍

[kernusr]

Is there some secret meaning in this?

Maybe because this interface did not exist back then?! 🤷‍♂️

The interface was added in php 5.5 and I'm surprised that no one noticed this in a rapidly developing project

So I can easily create a PR?

[Ocramius]

Yes please.

Do add a test though.