Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-7 file upload parameter naming consistency. #3

Open
2 tasks done
weierophinney opened this issue Dec 31, 2019 · 3 comments
Open
2 tasks done

PSR-7 file upload parameter naming consistency. #3

weierophinney opened this issue Dec 31, 2019 · 3 comments

Comments

@weierophinney
Copy link
Member

  • Is this related to quality assurance?
  • Is this related to documentation?
    Upgrading my setup to released version of Lock file maintenance #70 caused some confusion. Updating parameter to help resolve it, and suggest a documentation edit to explain where the instances could come from, as I couldn't figure it out without looking at the diff changes of previous PR refactorings.

Add missing unit tests for new options.


Originally posted by @alextech at zendframework/zend-filter#82

@weierophinney
Copy link
Member Author

Thanks @froschdesign for review and catching same inconsistencies that tripped me up yesterday!
Do you have a a hint on why 5.6 php travis is failing? I did not modify anything travis environment related to @weierophinney work, so would think it should work continuing from his setup.


Originally posted by @alextech at zendframework/zend-filter#82 (comment)

@weierophinney
Copy link
Member Author

PSR-17, which is used via the package psr/http-factory, requires PHP 7. Mark those tests as requiring PHP 7 using @require PHP 7.


Originally posted by @weierophinney at zendframework/zend-filter#82 (comment)

@weierophinney
Copy link
Member Author

@alextech As it is now it introduces BC Break. We can avoid it by deprecating previous keys and adding new. Also we need to keep old setter/getter (marked as deprecated) and proxy to new one.


Originally posted by @michalbundyra at zendframework/zend-filter#82 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant