Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventManagerAwareInterface and EventManagerAwareTrait parameters have different names #41

Open
rogervila opened this issue Jan 17, 2023 · 0 comments
Open

EventManagerAwareInterface and EventManagerAwareTrait parameters have different names #41

rogervila opened this issue Jan 17, 2023 · 0 comments
Labels
Bug Something isn't working

Comments

@rogervila
Copy link

Bug Report

On the EventManagerAwareInterface, the parameter for setEventManager method is called $eventManager while on EventManagerAwareTrait is called $events.

This causes Psalm errors when using the Trait. I can open a PR to use the same variable name, but we have to decide which one to use.

Q A
Version(s) 3.10.x

Summary

Psalm triggers a ParamMismatch error when using the EventManagerAwareTrait

Current behavior

Affects Psalm analysis only

How to reproduce

check this Pull Request comment

Expected behavior

Once the parameter name remains the same, the error will disappear.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rogervila