Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack Typechecker definitions needed #21

Closed
weierophinney opened this issue Dec 31, 2019 · 4 comments
Closed

Hack Typechecker definitions needed #21

weierophinney opened this issue Dec 31, 2019 · 4 comments

Comments

@weierophinney
Copy link
Member

Hi!

This module is excellent, but in a strict Hack project, is has no use, unfortunately, because of the lack of typechecker definitions.

Me and, for sure, many others, would appreciate if you wrote typechecker definitions!


Originally posted by @barbu110 at zendframework/zend-diactoros#180

@weierophinney
Copy link
Member Author

Would you be willing to provide a patch with them, please?


Originally posted by @weierophinney at zendframework/zend-diactoros#180 (comment)

@weierophinney
Copy link
Member Author

I am working on something, but I do not have time to finish them very soon.


Originally posted by @barbu110 at zendframework/zend-diactoros#180 (comment)

@weierophinney
Copy link
Member Author

@barbu110 What's the problem in a strict typed PHP 7 project?


Originally posted by @sandrokeil at zendframework/zend-diactoros#180 (comment)

@weierophinney
Copy link
Member Author

@sandrokeil, not PHP 7, Hack. The HHVM typechecker won't recognize the code of the module because it written in <?php, not <?hh, so .hhi definitions must be provided.


Originally posted by @barbu110 at zendframework/zend-diactoros#180 (comment)

@Xerkus Xerkus closed this as completed May 1, 2023
@Xerkus Xerkus closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants