Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of php 8.4 for 2.x series #206

Open
HLeithner opened this issue Dec 10, 2024 · 4 comments
Open

Support of php 8.4 for 2.x series #206

HLeithner opened this issue Dec 10, 2024 · 4 comments

Comments

@HLeithner
Copy link

Hi,

I'm not sure what's the support status of version 2.26 series is, so I wanted to ask if you going to release 2.x version which is marked to support php 8.4?

thanks

@gsteel
Copy link
Member

gsteel commented Dec 10, 2024

It's pretty unlikely. 3.0 has been out over 1 and a half years now and upgrading shouldn't be a big deal: https://docs.laminas.dev/laminas-diactoros/v3/migration/

@HLeithner
Copy link
Author

Thats a kind of issue for us at joomla. Because it would mean we need to update a core dependency within our minor version update, which breaks our b/c policy...

So the question is, how much work is it to validate 2.x against php 8.4?

@weierophinney
Copy link
Member

I just forked off of the 2.26.x branch to test this out, updating the supported versions to be 8.1-8.4. Unit tests and CS checks run fine; psalm is the bigger issue, with 59 new issues found. 4 are unused baselines; the majority are RedundantCondition or RiskyTruthyFalsyComparison issues.

From a functionality point of view, this is not a hard one to do, since the tests pass and CS passes; it's the QA part (with regards to Psalm errors) that may take more effort, and it's harder to estimate. I know I don't have time to work on it, but I'd certainly entertain a PR from somebody off the 2.26.x branch (for a 2.27.0 release).

@HLeithner
Copy link
Author

thanks, sounds great, I will see if I can convince someone to create a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants