Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another redis cluster with SSL support for QA runs #88

Open
boesing opened this issue Apr 10, 2024 · 0 comments
Open

Add another redis cluster with SSL support for QA runs #88

boesing opened this issue Apr 10, 2024 · 0 comments

Comments

@boesing
Copy link
Member

boesing commented Apr 10, 2024

Feature Request

Q A
New Feature yes
BC Break no

Summary

With #85, we allow SSL context options to be passed to the redis cluster. However, the current implementation of the integration testing does not support SSL as the redis service running the cluster does not support SSL to be enabled.
We use https://github.com/vishnudxb/docker-redis-cluster for integration tests, so that might need patch where SSL could be enabled. I do not have time for this right now and thus won't give it a shot, but maybe some1 else might want to have that.
IMHO its worth to have SSL support properly integration tested here so that our users can trust that we know everything is working when configuring stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant