Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release automation broken on this repository? #11

Closed
Ocramius opened this issue Dec 9, 2022 · 3 comments
Closed

Release automation broken on this repository? #11

Ocramius opened this issue Dec 9, 2022 · 3 comments
Assignees
Labels
Bug Something isn't working

Comments

@Ocramius
Copy link
Member

Ocramius commented Dec 9, 2022

Bug Report

Q A
Version(s) 1.2.0

Summary

See https://github.com/laminas/laminas-cache-storage-adapter-benchmark/actions/runs/3655683449/jobs/6177279507

Apparently, our release automation is failing to create a release:

In invariant_violation.php line 16:
                                                
  [Psl\Exception\InvariantViolationException]   
  Failed to create release through GitHub API.  

Branch switching also didn't work.

@Ocramius Ocramius added the Bug Something isn't working label Dec 9, 2022
@Ocramius Ocramius added this to the 1.3.0 milestone Dec 9, 2022
@Ocramius Ocramius self-assigned this Dec 9, 2022
@boesing
Copy link
Member

boesing commented Dec 9, 2022

Yes, the automatic-releases is broken in plenty of those components which were created after the initial introduction of the automatic-releases.

I have no idea if I do not have sufficient permissions or sth. like this but it seems that the secrets needed to access the API is not available for some components.

Sadly the error reporting of automatic-releases is not really clear about the "why". Asserting stuff is good for the happy-path but in case a problem occurs, it gives exactly no information about the problem itself.

Thats why I was not able to fix that problem but I could narrow it down to the place where the github release is actually created. Maybe the github release does not allow empty release description or sth. like this, but I have no idea without proper error reporting.

@Ocramius
Copy link
Member Author

Ocramius commented Dec 9, 2022

I have no idea if I do not have sufficient permissions or sth.

Hmm, the organization secrets are not overridden here: same permissions as everything else.

Asserting stuff is good for the happy-path but in case a problem occurs, it gives exactly no information about the problem itself.

We could raise logging verbosity (needs ejecting of the reusable workflow, while we try it).

I had similar issues in Roave/DocbookTool#232

Practically, we set the LOG_LEVEL environment variable to DEBUG, and we should see full request/response cycles.

Ref: https://github.com/laminas/automatic-releases/blob/f01e2555db36adfa0ba743b299dcd60d32394e80/src/Environment/EnvironmentVariables.php#L70
Ref: laminas/automatic-releases#205

@Xerkus Xerkus removed this from the 1.3.0 milestone Jan 7, 2024
@Xerkus
Copy link
Member

Xerkus commented Jan 7, 2024

Whatever it was, it was resolved.

@Xerkus Xerkus closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants