Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If it fails it doesn't resolve (?) #2

Open
niftylettuce opened this issue Mar 7, 2018 · 1 comment
Open

If it fails it doesn't resolve (?) #2

niftylettuce opened this issue Mar 7, 2018 · 1 comment

Comments

@niftylettuce
Copy link
Collaborator

Should we just return false instead of rejecting?
@niftylettuce
Copy link
Collaborator Author

resolve(true) here instead https://github.com/niftylettuce/gulp-haschanged-deps-async/blob/master/index.js#L44-L45?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@niftylettuce