Automate default policies update process #18
Conversation
jopemachine
commented
Dec 9, 2022
•
jopemachine
commented
- This PR automates the default policy update process using some python scripts and Github Action (Update seccomp profiles #10).
jopemachine
force-pushed
the
main
branch
4 times, most recently
from
ff69af1 to
b4a733b
Compare
jopemachine
changed the title
jopemachine
changed the title
scripts/update-policy.py
Outdated
| return super(OYAMLDumper, self).increase_indent(flow, False) | ||
|
|
||
|
|
||
| def lense(obj, *args): |
There was a problem hiding this comment.
I wrote this utility function to simplify codes,
but I think utility like dot-prop looks also good.
get_property({'foo': {'bar': 'unicorn'}}, 'foo.bar');
//=> 'unicorn'
get_property({'foo': {'bar': 'a'}}, 'foo.notDefined.deep');
//=> None
There was a problem hiding this comment.
We actually already have one implementation 😉: https://github.com/lablup/backend.ai/blob/e2e18a2/src/ai/backend/common/utils.py#L107
There was a problem hiding this comment.
If there is a well-packaged 3rd-party library with a clean API, I think it is also good to use one.
There was a problem hiding this comment.
I copied and pasted the nmget code, but maybe making it as a separate lib named nmget might be better idea to maintain.
scripts/update-policy.py
Outdated
| return super(OYAMLDumper, self).increase_indent(flow, False) | ||
|
|
||
|
|
||
| def lense(obj, *args): |
There was a problem hiding this comment.
We actually already have one implementation 😉: https://github.com/lablup/backend.ai/blob/e2e18a2/src/ai/backend/common/utils.py#L107
scripts/update-policy.py
Outdated
| return super(OYAMLDumper, self).increase_indent(flow, False) | ||
|
|
||
|
|
||
| def lense(obj, *args): |
There was a problem hiding this comment.
If there is a well-packaged 3rd-party library with a clean API, I think it is also good to use one.
|
Ubuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
