Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when no apps match query #148

Closed
BlockListed opened this issue Oct 8, 2023 · 2 comments
Closed

Panic when no apps match query #148

BlockListed opened this issue Oct 8, 2023 · 2 comments

Comments

@BlockListed
Copy link
Contributor

Recreate:

  • Open yofi
  • Type something, where no apps match the query
  • Press enter and a panic will happen.

Problem:

When this panic occurs, the yofi interface doesn't close, which makes it take over all keyboard and mouse input, until I kill yofi.

@l4l
Copy link
Owner

l4l commented Oct 9, 2023

I cannot reproduce that.

  1. Could you give a backtrace (e.g launch with gdb or just pstack)?
  2. Do you have notify-send binary and it's working fine on it's own?

@BlockListed
Copy link
Contributor Author

I cannot reproduce that.

1. Could you give a backtrace (e.g launch with gdb or just pstack)?

2. Do you have notify-send binary and it's working fine on it's own?

The notify-send binary hangs on my system (arch x86_64) when there is no notification daemon. This issue was a misdiagnosis of the actual problem, which was notify-send being called without a timeout when panicking. I addressed this in my companion PR #149 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants