Skip to content

Commit 71c3d61

Browse files
committed
Merge pull request KhronosGroup#1199 from zhenyao/prog
Fix bugs in gl-object-get-calls.js
2 parents f1085b9 + 02ada31 commit 71c3d61

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

sdk/tests/js/tests/gl-object-get-calls.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -296,12 +296,15 @@ if (contextVersion > 1) {
296296
var buffer = gl.createBuffer();
297297
gl.bindBuffer(gl.TRANSFORM_FEEDBACK_BUFFER, buffer);
298298
gl.bufferData(gl.TRANSFORM_FEEDBACK_BUFFER, 1024, gl.DYNAMIC_DRAW);
299+
var uniformBlockProgram = wtu.loadUniformBlockProgram(gl);
299300
var transformFeedbackVars = ["normal", "ecPosition"];
300301
gl.transformFeedbackVaryings(uniformBlockProgram, transformFeedbackVars, gl.INTERLEAVED_ATTRIBS);
301-
var uniformBlockProgram = wtu.loadUniformBlockProgram(gl);
302-
shouldBe('gl.getProgramParameter(standardProgram, gl.ACTIVE_UNIFORM_BLOCKS)', '1');
303-
shouldBe('gl.getProgramParameter(standardProgram, gl.TRANSFORM_FEEDBACK_VARYINGS)', '2');
304-
shouldBe('gl.getProgramParameter(standardProgram, gl.TRANSFORM_FEEDBACK_BUFFER_MODE)', 'gl.INTERLEAVED_ATTRIBS');
302+
gl.linkProgram(uniformBlockProgram);
303+
shouldBe('gl.getProgramParameter(uniformBlockProgram, gl.LINK_STATUS)', 'true');
304+
shouldBe('gl.getError()', 'gl.NO_ERROR');
305+
shouldBe('gl.getProgramParameter(uniformBlockProgram, gl.ACTIVE_UNIFORM_BLOCKS)', '1');
306+
shouldBe('gl.getProgramParameter(uniformBlockProgram, gl.TRANSFORM_FEEDBACK_VARYINGS)', '2');
307+
shouldBe('gl.getProgramParameter(uniformBlockProgram, gl.TRANSFORM_FEEDBACK_BUFFER_MODE)', 'gl.INTERLEAVED_ATTRIBS');
305308
}
306309
var program = standardProgram;
307310
var validArrayForProgramParameter = [

sdk/tests/resources/uniformBlockShader.frag

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,14 @@
2323
** MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS.
2424
*/
2525

26+
precision mediump float;
27+
2628
in vec3 normal;
2729
in vec4 ecPosition;
2830

31+
out vec4 fragColor;
32+
2933
void main()
3034
{
31-
gl_FragColor = vec4(v_normal/2.0+vec3(0.5), 1);
35+
fragColor = vec4(normal/2.0+vec3(0.5), 1);
3236
}

0 commit comments

Comments
 (0)