Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell-pop-universal-key not working #67

Open
doolio opened this issue Mar 9, 2021 · 2 comments
Open

shell-pop-universal-key not working #67

doolio opened this issue Mar 9, 2021 · 2 comments

Comments

@doolio
Copy link

doolio commented Mar 9, 2021

I have the following confisguration in my init.el.

(use-package shell-pop                  ; Pop up shell/terminal window.
  :defer 2)

And I have set the following via the customize interface.

 '(shell-pop-shell-type
   (quote
    ("ansi-term" "*ansi-term*"
     (lambda nil
       (ansi-term shell-pop-term-shell)))))
 '(shell-pop-universal-key "C-S-t")

However, despite setting what universal key to use via the Customize interface when C-h v shell-pop-universal-key it says the value is nil but that it's value was changed outside Customize. I use the helpful package which shows further down that the saved value is indeed C-S-t so I don't understand why the setting doesn't stick. If I M-x shell-pop then subsequent invocations of C-S-t will pop the terminal as expected.

This happens with 26.2. Oddly, on another machine where I'm using 27.1 and vterm instead of ansi-term it works though my keybinding is s-t. On the machine running 26.2, I cannot use vterm and cannot set the super key. Hence, why I'm using ansi-term and C-S-t. But otherwise the rest of my configuration on both machines is identical.

@dalanicolai
Copy link

dalanicolai commented Jul 30, 2021

EDIT

I thought I was checking out Spacemacs issues (but now I see that I selected the wrong browser tab), but I'll keep the comment here as it might still be informative

END EDIT

It looks like this is already available under SPC '. Is there some reason why you are redefining this?

Also, when I set shell-pop-universal-key via the customize menu, it works correctly (i.e. C-S-t gets bound to shell-pop. But I am on Emacs 28.0.50).

Finally, you could rebind spacemacs/default-pop-shell e.g. using:
(global-set-key (kbd "C-S-t") 'spacemacs/default-pop-shell)

@doolio
Copy link
Author

doolio commented Jul 30, 2021

Thanks for your input Daniel. I redefine to C-S-t as I didn't want to use that suggested here in the README namely C-t as that is already used for transpose-chars. I don't use Spacemacs myself. Good to know you don't experience my issue in 28.0.50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants