Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the proper way to set the shell type #62

Open
hammerandtongs opened this issue May 12, 2019 · 0 comments
Open

Document the proper way to set the shell type #62

hammerandtongs opened this issue May 12, 2019 · 0 comments

Comments

@hammerandtongs
Copy link

Despite the amount of good documentation for this package I still had basic trouble even getting it to work.

(use-package shell-pop :ensure t :custom (shell-pop-shell-type '("eshell" "eshell" (lambda () (eshell)))) (shell-pop-full-span t))

Was where I ended up.

The fundamental issue was that shell-pop-shell-type doesn't take "eshell" or 'eshell but instead that full chunk of code but that didn't seem clear to me from reading the documentation.

I would ask that you add the eshell line in its entirety (and the other shells) explicitly in the documentation.

I also think adding the use-package boilerplate would be a nice thing to add these days. A small note that using ":custom" is important since shell-pop uses customize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant