Skip to content

Crash for Master Dump when changing languages #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Leanny opened this issue Feb 27, 2020 · 2 comments
Open

Crash for Master Dump when changing languages #54

Leanny opened this issue Feb 27, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Leanny
Copy link

Leanny commented Feb 27, 2020

Changing the Language will result in no strings being passed to the Master Dump window when clicking on it without either rebooting the software or populating the strings by clicking on one of the other buttons.

To Reproduce:

  • Assumption: SW is loaded, language is English.
  • Options -> Language -> カタカナ
  • Click MasterDump
  • Click Nest Encounters

It looks like ROM.GetStrings results in an empty array which causes the exception
@sora10pls sora10pls added the bug Something isn't working label May 27, 2020
@Kayo-CPU
Copy link

No update ?

@duckdoom4
Copy link
Collaborator

Not that many devs around that still do any swsh updates. Feel free to make a PR to get it fixed tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Leanny @sora10pls @duckdoom4 @Kayo-CPU