Skip to content

Commit f44b580

Browse files
committed
refactor(View): Move View implementation to View directory
Signed-off-by: Ivin Joel Abraham <[email protected]>
1 parent 878dae5 commit f44b580

File tree

12 files changed

+56
-43
lines changed

12 files changed

+56
-43
lines changed

src/app.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
use crate::viewmodels::ViewModel;
1+
use crate::{viewmodels::ViewModel, views::View};
22
use std::collections::HashMap;
33

44
use color_eyre::eyre::Result;
55
use ratatui::crossterm::event::{self, Event, KeyEventKind};
66

7-
use crate::model::{screens::View, Model};
7+
use crate::model::Model;
88

99
#[allow(dead_code)]
1010
pub struct App {

src/handler/bookmarked.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,11 @@ use std::ops::ControlFlow;
99
use crate::{
1010
loading_screen,
1111
lore::lore_session::B4Result,
12-
model::{screens::View, Model},
13-
views::popup::{help::HelpPopUpBuilder, info_popup::InfoPopUp, PopUp},
12+
model::Model,
13+
views::{
14+
popup::{help::HelpPopUpBuilder, info_popup::InfoPopUp, PopUp},
15+
View,
16+
},
1417
};
1518

1619
pub fn handle_bookmarked_patchsets<B>(

src/handler/details_actions.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,11 @@ use std::time::Duration;
88

99
use crate::{
1010
infrastructure::terminal::{setup_user_io, teardown_user_io},
11-
model::{screens::View, Model},
12-
views::popup::{help::HelpPopUpBuilder, review_trailers::ReviewTrailersPopUp, PopUp},
11+
model::Model,
12+
views::{
13+
popup::{help::HelpPopUpBuilder, review_trailers::ReviewTrailersPopUp, PopUp},
14+
View,
15+
},
1316
};
1417

1518
use super::wait_key_press;

src/handler/edit_config.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
use ratatui::crossterm::event::{KeyCode, KeyEvent};
22

33
use crate::{
4-
model::{screens::View, Model},
5-
views::popup::{help::HelpPopUpBuilder, PopUp},
4+
model::Model,
5+
views::{
6+
popup::{help::HelpPopUpBuilder, PopUp},
7+
View,
8+
},
69
};
710

811
pub fn handle_edit_config(model: &mut Model, key: KeyEvent) -> color_eyre::Result<()> {

src/handler/latest.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,11 @@ use std::ops::ControlFlow;
99
use crate::{
1010
loading_screen,
1111
lore::lore_session::B4Result,
12-
model::{screens::View, Model},
13-
views::popup::{help::HelpPopUpBuilder, info_popup::InfoPopUp, PopUp},
12+
model::Model,
13+
views::{
14+
popup::{help::HelpPopUpBuilder, info_popup::InfoPopUp, PopUp},
15+
View,
16+
},
1417
};
1518

1619
pub fn handle_latest_patchsets<B>(

src/handler/mail_list.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
use crate::views::View;
12
use ratatui::{
23
crossterm::event::{KeyCode, KeyEvent},
34
prelude::Backend,
@@ -8,7 +9,7 @@ use std::ops::ControlFlow;
89

910
use crate::{
1011
loading_screen,
11-
model::{screens::View, Model},
12+
model::Model,
1213
views::popup::{help::HelpPopUpBuilder, PopUp},
1314
};
1415

src/handler/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ use std::{
1717

1818
use crate::{
1919
loading_screen,
20-
model::{screens::View, Model},
21-
views::draw_ui,
20+
model::Model,
21+
views::{draw_ui, View},
2222
};
2323

2424
use bookmarked::handle_bookmarked_patchsets;

src/model/mod.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ use crate::{
1717
lore_session::{self, B4Result},
1818
patch::{Author, Patch},
1919
},
20-
views::popup::{info_popup::InfoPopUp, PopUp},
20+
views::{
21+
popup::{info_popup::InfoPopUp, PopUp},
22+
View,
23+
},
2124
};
2225

2326
use config::Config;
@@ -29,7 +32,6 @@ use screens::{
2932
edit_config::EditConfig,
3033
latest::LatestPatchsets,
3134
mail_list::MailingListSelection,
32-
View,
3335
};
3436

3537
/// Type that represents the overall state of the application. It can be viewed

src/model/screens/details_actions.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,9 @@ use crate::{
1414
patch::{Author, Patch},
1515
},
1616
model::config::{Config, KernelTree},
17+
views::View,
1718
};
1819

19-
use super::View;
20-
2120
pub struct DetailsActions {
2221
pub representative_patch: Patch,
2322
/// Raw patches as plain text files

src/model/screens/mod.rs

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,5 @@
1-
use crate::viewmodels::ViewModelState;
2-
31
pub mod bookmarked;
42
pub mod details_actions;
53
pub mod edit_config;
64
pub mod latest;
75
pub mod mail_list;
8-
9-
#[derive(Copy, Debug, Clone, PartialEq, Eq, Hash)]
10-
pub enum View {
11-
MailingListSelection,
12-
BookmarkedPatchsets,
13-
LatestPatchsets,
14-
PatchsetDetails,
15-
EditConfig,
16-
}
17-
18-
impl View {
19-
#[allow(dead_code, unused_variables)]
20-
pub fn draw_screen(&self, state: ViewModelState) {
21-
match self {
22-
View::MailingListSelection => todo!(),
23-
View::BookmarkedPatchsets => todo!(),
24-
View::LatestPatchsets => todo!(),
25-
View::PatchsetDetails => todo!(),
26-
View::EditConfig => todo!(),
27-
}
28-
}
29-
}

0 commit comments

Comments
 (0)