Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker images amount restriction #122

Open
vkostetski opened this issue Apr 19, 2016 · 6 comments · May be fixed by #163
Open

Docker images amount restriction #122

vkostetski opened this issue Apr 19, 2016 · 6 comments · May be fixed by #163

Comments

@vkostetski
Copy link

vkostetski commented Apr 19, 2016 •
edited
Loading

ENV_DEFAULT_REPOSITORIES_PER_PAGE=20
Open UI. We have more than 100 images in repo. Clicking "Show All" at the bottom of the page:

Expected behavior

Expected listing of all images.

Actual behavior

Only 100 are displayed.

Specifications

Docker:
Client:
Version: 1.8.2
API version: 1.20
Package Version: docker-1.8.2-7.el7.x86_64
Go version: go1.4.2
Git commit: bb472f0/1.8.2
Built:
OS/Arch: linux/amd64

OS RHEL 7:
3.10.0-327.10.1.el7.x86_64

docker-registry-frontend:
Commit
@arthurdk
Copy link
Contributor

Short answer as I'm in a hurry but I ll edit this afternoon when I have more time.

It is basically because of the implantation of the Docker Registry.

See the implementation (https://github.com/docker/distribution/blob/master/registry/handlers/catalog.go)

But maybe we should let the user know that the maximum is up to 100 by request.

@mnarusze
Copy link

mnarusze commented Jun 2, 2016

'last' parameter should be used as described in the API spec to go page by page.

@drallieiv
Copy link

+1 on @mnarusze comment :
when provisionning data, if show all is selected, it should call the api in loop /v2/_catalog?n=&last=<100thRepoFound> with the last item found from previous search until no results are found

@drallieiv drallieiv linked a pull request Jan 31, 2017 that will close this issue
Open
@drallieiv
Copy link

I can't really test it from work. If sometone with the issue can check with that PR, it would be nice.

@gtorre
Copy link

gtorre commented Sep 28, 2017

@drallieiv any updates on this?

@binhex
Copy link

binhex commented Nov 2, 2017 •
edited
Loading

just tripped up on this myself, setting the number to something high works around the issue e.g. ...repositories/99999

but it would be nice to have the 'all' limit working as designed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #122 : loop call if pagination set to "All" drallieiv/docker-registry-frontend
6 participants
@drallieiv @binhex @mnarusze @gtorre @arthurdk @vkostetski