Fix special characters in request params #184
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quote from itty-router-openapi/issues/88 @gimenete
Given an endpoint like this:
Making a query to
/something/user%3A1234
returns the following response:id: user%3A1234
. While it should beid: user:1234
.The fix here was to
decodeURIComponent
the request url before parsing the parameters, i've also added a unit test for this, but now this test is failing due toURI malformed
.@kwhitley can you propose a fix here, should i edit the failing test to a valid one?
Type of Change (select one and follow subtasks)