Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Quickconnect; Wait for redirect #48

Open
proohit opened this issue Mar 23, 2020 · 1 comment
Open

Support for Quickconnect; Wait for redirect #48

proohit opened this issue Mar 23, 2020 · 1 comment

Comments

@proohit
Copy link

proohit commented Mar 23, 2020

It would be awesome if the library supports quickconnect (QC). The problem mainly is that quickconnect first attempts to redirect to the "correct" url.

When making a request e.g. via CLI, the "Connecting..." page gets parsed by syno.js instead of the actual JSON data. Thus, there will be several exceptions while parsing the response.

Maybe it could wait for redirects before parsing the final response data? (https://stackoverflow.com/questions/7323932/how-do-you-follow-an-http-redirect-in-node-js)

@kwent
Copy link
Owner

kwent commented May 26, 2020

That is a good idea. Feel free to open a PR. I would love to support quickconnect in syno.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants