Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some actions are missing in delete() method of AbstractEngine class #9

Open
psam44 opened this issue Apr 23, 2024 · 1 comment
Open

Comments

@psam44
Copy link

psam44 commented Apr 23, 2024

In AbstractEngine.ts, create() takes care of the index creation with createEngineIndex() and of the config collection creation with engineConfigManager.createCollection().

BUT, in delete(), there are no such reverse actions, to delete the config collection and finally the index itself.

version 1.2.0.

@rolljee
Copy link
Contributor

rolljee commented Jun 4, 2024

This is tricky and must be discussed in house, because deleting a index can result in deleting things that have been created by other plugins and thus, this can be destructive for the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants