proposal_creator_election macro are +/- off by 1 because congruence

[Jovonni]

bug quoted from the paper repo:
paper issue

The proposal creation function still iterates congruently, but the expected node id is not what is expected. All tests pass now, but this is was the bug. It didn't stop proposal generation for nodes, but it chose the wrong participant to create the next proposal

wrong:

AfricaOS/core/macros/src/lib.rs

Line 40 in ec080b3

( ($latest_block_id + 1) % ( ($peer_length + 1) as i64) ) + 1

Should be:

($latest_block_id % $peer_length as i64) + 1

Because

[print( ( (x+1) % (3 + 1) ) + 1 ) for x in range(0,10)]

2
3
4
1
2
3
4
1
2
3

but this is correct

[print((x % 3) + 1) for x in range(0,10)]

1
2
3
1
2
3
1
2
3
1

This works for three, and for 2 peers

[print((x % 2) + 1) for x in range(0,10)]

1
2
1
2
1
2
1
2
1
2

and for 5 peers

[print((x % 5) + 1) for x in range(0,10)]

1
2
3
4
5
1
2
3
4
5