Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] restart a running workflow will cause workflow excutor always return Skipped #191

Open
MengJiapeng opened this issue Aug 14, 2024 · 2 comments

Comments

@MengJiapeng
Copy link

Describe the bug

restart a running workflow will cause workflow excutor always return Skipped

To Reproduce

  1. start a workflowrun
  2. use vela-cli to restart the workflowrun
    vela workflow restart xxx --step xxx
  3. workflow will not handled by controller, and the log like this
    "Skip this reconcile" workflowrun="default/test-xxx" spanID="i-dv1uiiok"

Expected behavior

Screenshots

Workflow Version
v0.6.0

Cluster information

Additional context

@MengJiapeng
Copy link
Author

The reason caused the issue is that vela-cli will clean the step status when restart workflow, while workflow controller cached the step status count in memory and compare the count before reconcile, if the count is smaller than last cached count, it will skip reconcile. I'm confused about the step status count cache, is it still necessary?
here is the related code in workflow controller

if cacheValue, ok := StepStatusCache.Load(cacheKey); ok {

@FogDong
Copy link
Member

FogDong commented Aug 14, 2024

This cache was originally used to handle the cache update problem caused by controller reconcile, it's an occasional problem so I'm no sure if we should disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants