Chore: replace deprecated command with environment file #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jongwoo Han <[email protected]>
jongwooo
requested review from
barnettZQG,
wonderflow and
chivalryq
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
===========================================
- Coverage 59.01% 32.59% -26.43%
===========================================
Files 116 91 -25
Lines 19846 17940 -1906
===========================================
- Hits 11713 5848 -5865
- Misses 6696 11212 +4516
+ Partials 1437 880 -557
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Closes #894
Update
.github/workflows/release.ymlto use environment file instead of deprecatedset-outputcommand.For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
I found the workflow file that use
set-outputcommand through the following command:AS-IS
echo ::set-output name=VERSION::${VERSION}TO-BE
echo "VERSION=${VERSION}" >> $GITHUB_OUTPUTI have:
yarn lintto ensure the frontend changes are ready for review.make reviewableto ensure the server changes are ready for review.backport release-x.ylabels to auto-backport this PR if necessary.Special notes for your reviewer
None