Terraform state backup and restore tool #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: loheagn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=========================================
Coverage ? 78.18%
=========================================
Files ? 23
Lines ? 1595
Branches ? 0
=========================================
Hits ? 1247
Misses ? 268
Partials ? 80
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
zzxwill
reviewed
May 25, 2022
| }, | ||
| } | ||
| restoreCmd.Flags().StringVar(&stateJSONPath, "state", "state.back.json", "the path of the backed up Terraform state file") | ||
| restoreCmd.Flags().StringVar(&configurationPath, "configuration", "configuration.back.yaml", "the path of the backed up configuration objcet yaml file") |
There was a problem hiding this comment.
Suggested change
| restoreCmd.Flags().StringVar(&configurationPath, "configuration", "configuration.back.yaml", "the path of the backed up configuration objcet yaml file") | |
| restoreCmd.Flags().StringVar(&configurationPath, "configuration", "configuration.yaml", "the path of the backed up configuration objcet yaml file") |
Normally the configuration file is there, no need to have a backup.
zzxwill
reviewed
May 25, 2022
Signed-off-by: loheagn <[email protected]>
zzxwill
reviewed
May 26, 2022
hack/tool/backup_restore/README.md
Outdated
|
|
||
| ## `restore` | ||
|
|
||
| The main usage of the `restore` subcommand is to import an "outside" Terraform instance (maybe created by the terraform command line or managed by another terraform-controller before) to the terraform-controller in the target kubernetes without recreating the cloud resources. |
There was a problem hiding this comment.
Suggested change
| The main usage of the `restore` subcommand is to import an "outside" Terraform instance (maybe created by the terraform command line or managed by another terraform-controller before) to the terraform-controller in the target kubernetes without recreating the cloud resources. | |
| The main usage of the `restore` subcommand is to import an "outside" Terraform instance (maybe created by the terraform command line or managed by another terraform-controller before) to the terraform-controller in the target Kubernetes without recreating the cloud resources. |
zzxwill
reviewed
May 26, 2022
| To use the `restore` subcommand, you should: | ||
|
|
||
| 1. Prepare the `configuration.yaml` file and the `state.json` file whose content is the state json of the Terraform instance which would be imported. | ||
|
|
There was a problem hiding this comment.
This is a typical scenario, great! Here is another one, please cover it in this PR or in a later one #310 (comment).
There was a problem hiding this comment.
Is this should be covered by backup command?
There was a problem hiding this comment.
I can add the backup command in the next PR.
Signed-off-by: loheagn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #310
Signed-off-by: loheagn [email protected]