-
Notifications
You must be signed in to change notification settings - Fork 68
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to propagate annotationa and labels to the terraform apply and destroy jobs #254
Comments
anoop2811
changed the title
Provide a way to propagate labels to the terraform apply and destroy jobs
Provide a way to propagate annotationa and labels to the terraform apply and destroy jobs
Feb 28, 2022
An example Job creation that works when we are able to disable istio injection that worked would look like this:
|
@zzxwill Would it make sense to get these labels from the helm chart as user provided to start? |
@anoop2811 It makes sense. You can set it directly like the code sample. In the future, if we need to interact with Isitio, we can expose the setting of the annotation to user-side:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A problem we are facing is when we use istio, it enables a sidecar called istio-proxy due to which the job remains in the running status as it continues running even after the terraform-executor has completed. Due to this, the job continues to stay in the
Running
status. In order to disable istio for jobs, we will need to add the annotationsidecar.istio.io/inject: "false"
to the job. If we could propagate the annotation and labels from the application object to the jobs, it would help to selectively disable the sidecar injection.The text was updated successfully, but these errors were encountered: