Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add apply #89

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Feat: add apply #89

wants to merge 3 commits into from

Conversation

Somefive
Copy link
Collaborator

Fixes #10

@Somefive Somefive requested a review from FogDong as a code owner June 15, 2023 05:15
@Somefive Somefive marked this pull request as draft June 15, 2023 05:15
Signed-off-by: Yin Da <[email protected]>
Signed-off-by: Yin Da <[email protected]>
@Somefive Somefive force-pushed the feat/add-apply branch 2 times, most recently from 6b12b63 to 274bf1e Compare June 15, 2023 06:18
@codecov
Copy link

Codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 85.81% and project coverage change: +0.08 🎉

Comparison is base (2cef0c3) 87.78% compared to head (58c32e2) 87.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   87.78%   87.86%   +0.08%     
==========================================
  Files          81       85       +4     
  Lines        3871     4005     +134     
==========================================
+ Hits         3398     3519     +121     
- Misses        359      367       +8     
- Partials      114      119       +5     
Flag Coverage Δ
unit-test 87.86% <85.81%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
util/k8s/patch/patch.go 82.05% <57.14%> (-3.87%) ⬇️
util/k8s/apply/apply.go 84.09% <84.09%> (ø)
util/builder/option.go 100.00% <100.00%> (ø)
util/jsonutil/setter.go 100.00% <100.00%> (ø)
util/k8s/apply/types.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Yin Da <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate applicator.apply from kubevela repository to pkg
1 participant