Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide dex connector for GitHub Enterprise #464

Open
TommyHwang opened this issue Sep 8, 2022 · 2 comments
Open

Provide dex connector for GitHub Enterprise #464

TommyHwang opened this issue Sep 8, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@TommyHwang
Copy link

TommyHwang commented Sep 8, 2022

Background

Currently, dex connector is available for public GitHub use.

GitHub Enterprise requires additional host settings in dex-connector-def.yaml.

Related link

https://dexidp.io/docs/connectors/github/#github-enterprise

Need to be changed

def

github?: {
// +usage=GitHub client ID
clientID: string
// +usage=GitHub client secret
clientSecret: string
// +usage=GitHub redirect URI
redirectURI: string
}

ui-schema

- jsonKey: github
sort: 3
uiType: Ignore
validate:
required: true
conditions:
- jsonKey: type
op: "=="
value: "github"
subParameters:
- jsonKey: clientID
uiType: Password
sort: 1
- jsonKey: clientSecret
uiType: Password
sort: 3
- jsonKey: redirectURI
sort: 5

@barnettZQG
Copy link
Collaborator

@TommyHwang Welcome you to contribute to this and help to test.

@barnettZQG barnettZQG added the help wanted Extra attention is needed label Sep 9, 2022
@TommyHwang
Copy link
Author

TommyHwang commented Sep 14, 2022

Update

It is currently being tested on velaux after adding hostName.
velaux returns 500 internal error as shown below.

test-internal-error

So I'm checking api server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants