Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve static IP field not working #1113

Open
jsakil14 opened this issue Oct 18, 2024 · 7 comments
Open

preserve static IP field not working #1113

jsakil14 opened this issue Oct 18, 2024 · 7 comments

Comments

@jsakil14
Copy link

When I migrate from vmware to kubevirt using forklift , the preserve static IP filed when selected doesnt apply and defaults to Use System default setting. How do we enforce this ? I am using : latest images - let me know what logs are needed. Due to this , guest OS doesnt have the IP config preserved.

@jsakil14
Copy link
Author

@mnecas Is this relevant for the virt-io drivers for windows issue which was resolved yesterday?

@jsakil14
Copy link
Author

@jsakil14
Copy link
Author

Am trying to add this , but it just doesnt allow me.

k apply -f /var/folders/7g/kjjlhgyn65d_zw5zb8f6c_6c0000gp/T/kubectl-edit-894711451.yaml
error: error validating "/var/folders/7g/kjjlhgyn65d_zw5zb8f6c_6c0000gp/T/kubectl-edit-894711451.yaml": error validating data: ValidationError(Plan.spec): unknown field "preserveStaticIPs" in io.konveyor.forklift.v1beta1.Plan.spec; if you choose to ignore these errors, turn validation off with --validate=false
% cat /var/folders/7g/kjjlhgyn65d_zw5zb8f6c_6c0000gp/T/kubectl-edit-894711451.yaml

Please edit the object below. Lines beginning with a '#' will be ignored,

and an empty file will abort the edit. If an error occurs while saving this file will be

reopened with the relevant failures.

plans.forklift.konveyor.io "copy-of-windows" was not valid:

* : Invalid value: "The edited file failed validation": ValidationError(Plan.spec): unknown field "preserveStaticIPs" in io.konveyor.forklift.v1beta1.Plan.spec

apiVersion: forklift.konveyor.io/v1beta1
kind: Plan
metadata:
annotations:
populatorLabels: "True"
creationTimestamp: "2024-10-18T09:02:46Z"
generation: 2
name: copy-of-windows
namespace: konveyor-forklift
resourceVersion: "617907626"
uid: 5d79ebd5-3bd4-4cd7-ab3b-81f00361c354
spec:
archived: false
map:
network:
apiVersion: forklift.konveyor.io/v1beta1
kind: NetworkMap
name: copy-of-windows-7sj4h
namespace: konveyor-forklift
storage:
apiVersion: forklift.konveyor.io/v1beta1
kind: StorageMap
name: copy-of-windows-7tq46
namespace: konveyor-forklift
preserveStaticIPs: true
provider:
destination:
apiVersion: forklift.konveyor.io/v1beta1
kind: Provider
name: dev-kubevirt
namespace: konveyor-forklift
uid: 9869803a-4825-49cb-8bee-c0b9ba116030
source:
apiVersion: forklift.konveyor.io/v1beta1
kind: Provider
name: sbx-vc
namespace: konveyor-forklift
uid: 8df052e1-31e0-48bc-88c8-1d504e795889
targetNamespace: forklift-migration
vms:

  • id: vm-27411
    name: win-nextgen-01
    warm: false
    status:
    conditions:
  • category: Required
    lastTransitionTime: "2024-10-18T09:08:36Z"
    message: The migration plan is ready.
    status: "True"
    type: Ready
    migration: {}
    observedGeneration: 2

@mnecas
Copy link
Member

mnecas commented Oct 18, 2024

in your log the indenting broke so it's hard to read please use next time ``` in the start and end
The preserveStaticIPs should go the the plan spec

apiVersion: forklift.konveyor.io/v1beta1
kind: Plan
metadata:
annotations:
populatorLabels: "True"
creationTimestamp: "2024-10-18T09:02:46Z"
generation: 2
name: copy-of-windows
namespace: konveyor-forklift
resourceVersion: "617907626"
uid: 5d79ebd5-3bd4-4cd7-ab3b-81f00361c354
spec:
      preserveStaticIPs: true
....

but it looks like you put it in the storagemap

@jsakil14
Copy link
Author

in your log the indenting broke so it's hard to read please use next time ``` in the start and end The preserveStaticIPs should go the the plan spec

apiVersion: forklift.konveyor.io/v1beta1
kind: Plan
metadata:
annotations:
populatorLabels: "True"
creationTimestamp: "2024-10-18T09:02:46Z"
generation: 2
name: copy-of-windows
namespace: konveyor-forklift
resourceVersion: "617907626"
uid: 5d79ebd5-3bd4-4cd7-ab3b-81f00361c354
spec:
      preserveStaticIPs: true
....

but it looks like you put it in the storagemap

My bad - can you refer to this kubev2v/forklift-console-plugin#1133 (comment)

@mnecas
Copy link
Member

mnecas commented Oct 18, 2024

okay looks like forklift was not released with this feature yet...
proper fix: I need to do the release
WA/hack you can edit the: kubectl edit crd plans.forklift.konveyor.io and add there the preserveStaticIPs

preserveStaticIPs:
description: Preserve static IPs of VMs in vSphere
type: boolean

@mnecas
Copy link
Member

mnecas commented Oct 18, 2024

Or install it form the latest index

---
apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: forklift-konveyor
  namespace: openshift-marketplace
spec:
  displayName: Forklift
  publisher: Konveyor
  sourceType: grpc
  image: quay.io/kubev2v/forklift-operator-index:latest
  updateStrategy:
    registryPoll:
      interval: 10m0s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants