From bdbf7c74913e5c610b50e003ff40308743d59e58 Mon Sep 17 00:00:00 2001 From: Rick <1450685+LinuxSuRen@users.noreply.github.com> Date: Fri, 24 Sep 2021 19:49:07 +0800 Subject: [PATCH] Add flag completion for ks install command (#207) --- kubectl-plugin/install/installer.go | 2 ++ kubectl-plugin/install/k3d.go | 1 + kubectl-plugin/install/kind.go | 2 +- kubectl-plugin/install/kk.go | 3 +++ 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/kubectl-plugin/install/installer.go b/kubectl-plugin/install/installer.go index 25be2c1..20cda7b 100644 --- a/kubectl-plugin/install/installer.go +++ b/kubectl-plugin/install/installer.go @@ -33,6 +33,8 @@ You can get more details about the ks-installer from https://github.com/kubesphe "The nightly version you want to install") flags.StringArrayVarP(&opt.components, "components", "", []string{}, "The components that you want to Enabled with KubeSphere") + + _ = cmd.RegisterFlagCompletionFunc("components", common.PluginAbleComponentsCompletion()) return } diff --git a/kubectl-plugin/install/k3d.go b/kubectl-plugin/install/k3d.go index 7816ce1..7bab91e 100644 --- a/kubectl-plugin/install/k3d.go +++ b/kubectl-plugin/install/k3d.go @@ -53,6 +53,7 @@ You can get more details from https://github.com/rancher/k3d/`, _ = cmd.RegisterFlagCompletionFunc("image", common.ArrayCompletion("rancher/k3s:v1.19.14-k3s1", "rancher/k3s:v1.20.10-k3s1", "rancher/k3s:v1.21.4-k3s1")) + _ = cmd.RegisterFlagCompletionFunc("components", common.PluginAbleComponentsCompletion()) return } diff --git a/kubectl-plugin/install/kind.go b/kubectl-plugin/install/kind.go index f57f321..90822d7 100644 --- a/kubectl-plugin/install/kind.go +++ b/kubectl-plugin/install/kind.go @@ -41,7 +41,7 @@ ks install kind --nightly latest --components DevOps`, flags.BoolVarP(&opt.fetch, "fetch", "", true, "Indicate if fetch the latest config of tools") - _ = cmd.RegisterFlagCompletionFunc("components", common.ArrayCompletion("DevOps")) + _ = cmd.RegisterFlagCompletionFunc("components", common.PluginAbleComponentsCompletion()) return } diff --git a/kubectl-plugin/install/kk.go b/kubectl-plugin/install/kk.go index 06f27ca..1e488cf 100644 --- a/kubectl-plugin/install/kk.go +++ b/kubectl-plugin/install/kk.go @@ -44,6 +44,9 @@ ks install kk --version nightly --components devops`, "Indicate the container runtime type. Supported: docker, containerd") flags.BoolVarP(&opt.fetch, "fetch", "", true, "Indicate if fetch the latest config of tools") + + _ = cmd.RegisterFlagCompletionFunc("components", common.PluginAbleComponentsCompletion()) + _ = cmd.RegisterFlagCompletionFunc("components", common.ArrayCompletion("docker", "containerd")) return }