return failed status if container returns with non-zero code (#598)

Signed-off-by: Matthias Bertschy <[email protected]>

Author: matthyx

go.mod

@@ -33,10 +33,11 @@ require (
 	github.com/joncrlsn/dque v0.0.0-20241024143830-7723fd131a64
 	github.com/kubescape/backend v0.0.25
 	github.com/kubescape/go-logger v0.0.24
-	github.com/kubescape/k8s-interface v0.0.197
+	github.com/kubescape/k8s-interface v0.0.198
 	github.com/kubescape/storage v0.0.200
 	github.com/kubescape/workerpool v0.0.0-20250526074519-0e4a4e7f44cf
 	github.com/moby/sys/mountinfo v0.7.2
+	github.com/oleiade/lane/v2 v2.0.0
 	github.com/opencontainers/go-digest v1.0.0
 	github.com/opencontainers/image-spec v1.1.1
 	github.com/panjf2000/ants/v2 v2.11.3
@@ -245,7 +246,6 @@ require (
 	github.com/ncw/directio v1.0.5 // indirect
 	github.com/nwaples/rardecode v1.1.3 // indirect
 	github.com/oklog/ulid v1.3.1 // indirect
-	github.com/oleiade/lane/v2 v2.0.0 // indirect
 	github.com/olekukonko/tablewriter v0.0.5 // indirect
 	github.com/olvrng/ujson v1.1.0 // indirect
 	github.com/opencontainers/runtime-spec v1.2.1 // indirect

go.sum

@@ -704,8 +704,8 @@ github.com/kubescape/backend v0.0.25 h1:PLESA7KGJskebR5hiSqPeJ1cPQ8Ra+4yNYXKyIej
 github.com/kubescape/backend v0.0.25/go.mod h1:FpazfN+c3Ucuvv4jZYCnk99moSBRNMVIxl5aWCZAEBo=
 github.com/kubescape/go-logger v0.0.24 h1:JRNlblY16Ty7hD6MSYNPvWYDxNzVAufsDDX/sZJayL0=
 github.com/kubescape/go-logger v0.0.24/go.mod h1:sMPVCr3VpW/e+SeMaXig5kClGvmZbDXN8YktUeNU4nY=
-github.com/kubescape/k8s-interface v0.0.197 h1:v+frj62buBQ79/C5iZVKcDuwuZuw/pEQQasSO8fwFUk=
-github.com/kubescape/k8s-interface v0.0.197/go.mod h1:j9snZbH+RxOaa1yG/bWgTClj90q7To0rGgQepxy4b+k=
+github.com/kubescape/k8s-interface v0.0.198 h1:U7PNTyS9ZE9ZkSrLMclLO7Sz4grf/2CLbmpVT6Hc0nU=
+github.com/kubescape/k8s-interface v0.0.198/go.mod h1:j9snZbH+RxOaa1yG/bWgTClj90q7To0rGgQepxy4b+k=
 github.com/kubescape/storage v0.0.200 h1:gLCPiAPxDii03Jo326Ye0qx1cXOAz6KH+A9B0WuL1CE=
 github.com/kubescape/storage v0.0.200/go.mod h1:uv4LMQjcTYIn7bgyMFGc0UBZ3gxdl7MNixPSjALP08E=
 github.com/kubescape/workerpool v0.0.0-20250526074519-0e4a4e7f44cf h1:hI0jVwrB6fT4GJWvuUjzObfci1CUknrZdRHfnRVtKM0=

pkg/containerprofilemanager/v1/lifecycle.go

@@ -241,8 +241,7 @@ func (cpm *ContainerProfileManager) deleteContainer(container *containercollecti
 				container.K8s.PodName, container.K8s.ContainerName, containerID) == 0 {
 				entry.data.watchedContainerData.SetStatus(objectcache.WatchedContainerStatusCompleted)
 			} else {
-				// TODO return error code to storage instead of staying on learning
-				// so we can close the TS and move away - this will not reflect on the CP and AP/NN
+				entry.data.watchedContainerData.SetStatus(objectcache.WatchedContainerStatusFailed)
 			}
 
 			// Send container termination signal (blocking send, safe because monitoring goroutine is always running)

pkg/objectcache/shared_container_data.go

@@ -36,6 +36,7 @@ const (
 	WatchedContainerStatusInitializing WatchedContainerStatus = helpersv1.Initializing
 	WatchedContainerStatusReady        WatchedContainerStatus = helpersv1.Learning
 	WatchedContainerStatusCompleted    WatchedContainerStatus = helpersv1.Completed
+	WatchedContainerStatusFailed       WatchedContainerStatus = helpersv1.Failed
 
 	WatchedContainerStatusMissingRuntime WatchedContainerStatus = helpersv1.MissingRuntime
 	WatchedContainerStatusTooLarge       WatchedContainerStatus = helpersv1.TooLarge